-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
feat(display): reduce default breakpoint sizes #19759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
e20cfec to
2766105
Compare
4c970f9 to
6a3285f
Compare
|
I always though there is something off about those defaults. My only concern is the impact on
With rounding down to nearest 100px we would get: 100 * math.floor(map.get($grid-breakpoints, 'md') * 0.009375)
// or with math.div() to make it more obvious:
// 100 * math.floor(math.div(map.get($grid-breakpoints, 'md') * 0.9375, 100)) |
|
My biggest problem with the current ones is that they exactly match common screen resolutions (especially xl and xxl). Any sort of sidebar like edge's or firefox vertical tabs bumps you down a breakpoint for no real reason.
Yeah that seems better actually. Many screen sizes will still get a wider container with that change eg. 1080p goes from 1200 to 1400px. |
|
We could actually use container queries now, any thoughts on these questions? #18983 (comment) |
I think that ~55px margin is going to be perfect to account for this. |
https://m3.material.io/foundations/layout/applying-layout/window-size-classes
-55px for edge's stupid sidebar
reduced xxl to 4k at 175% scaling